Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
Closes #168
Changes:
cache_check
: whenever the cachecheck check api is run.cache_ping
: whenever a new value is written to the cacheIt also logs more data e.g. site identifier and session redis prefix so it might be obvious if these are broken or not correct to the site.I'm still a bit undecided whether site identifier or session redis prexis is useful. For e.g. if you had a cache issue such as another site (site B) using the same prefix, these logs would be written on Site Bs logs but would have Site A's prefix. But if you only knew about site A, you would have no idea how to find site B.Since event logs are logged, it could be possible to work this out if you grepped across all the site logs for a particular prefix and see what sites are putting those cachecheck/ping logs out.TODO after merging:
MOODLE_39_STABLE
-> [#165] Add cachecheck logging - MOODLE_39_STABLE cherry pick #167Pull request checks