Add admin setting for partial save #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been noticing some issues with excimer appearing in its own profiles when a site is suffering wide scale database issues. This has been traced back to the partial save during web processing, and occur when db writes for the save are taking a significant amount of time.
This goes against the design principle of do no harm, and really should have its own admin setting. The timing can be controlled by 'long_interval_s', but this is also used for saving profiles of finished cron tasks, so the new setting should be different.
This PR adds the setting (defaults to off) and updates the wording of the mentioned settings to reflect proper usage.
There's room to improve the performance of partial saves, but that would be a separate issue and a toggle would still be desired.