Use relative path to graph php files in template javascript #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjbutler
force-pushed
the
MOODLE_35_STABLE
branch
from
2bdb33f to
eaa378f
Compare
tonyjbutler
changed the title
This fixes a graph display bug for sites located in a wwwroot subdir.
brendanheywood
force-pushed
the
MOODLE_35_STABLE
branch
from
eaa378f to
a39c486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For (admittedly usually dev) Moodle sites located in a subdirectory of the apache root, the graphs can't be displayed because the template requests to the {...}graph.json.php files return 404 errors.
Prefixing the path with the actual wwwroot as defined in config.php fixes this.
Edit: Actually it doesn't (was testing in the wrong dev instance), but using a relative path does. These templates are only rendered in profile.php so this should be fine (I hope).