Add device experiment #79

bwalkerl · 2025-01-13T07:53:38Z

Closes #75
Closes #74 - Rather than converting everything to _before_session and trying to resolve other issues with $SESSION and $USER being null, it's safer to only have the new experiment type use it.

Re-add allow override of config.php from Allow override of config.php and move trigger to before session #74 #76 without the problematic _before_session changes
Adds new 'device' experiment type that uses _before_session
Moves js render logic from SESSION to a static variable in manager

classes/experiment_manager.php

lib.php

brendanheywood · 2025-01-13T08:19:22Z

lib.php

+
+        // Now, execute all commands in the arrays.
+        foreach ($commandarray as $shortname => $command) {
+            tool_abconfig_execute_command_array($command, $shortname);


I think it would be good to split out most of the logic above which figures out what to do, from the execution, so that we can unit test the first half

I think this depend on how much testing we want. I've left it as is for now, but I haven't gone too deep into testing the specific logic for devices (the tests I've added so far are variations of the original tests that have been slightly modified for devices).

Allow override of config.php

5bca44c