Fix mass copy/paste async task (#582)

* Remove batch transaction logic

* Remove unused code

* Add to changelog

CHANGES.md

@@ -4,7 +4,7 @@ Changelog
 3.0.0b134 (unreleased)
 ----------------------
 
-- Nothing changed yet.
+- Fix mass copy/paste functionality
 
 
 3.0.0b133 (2024-03-21)

castle/cms/tasks/content.py

@@ -42,11 +42,8 @@ def paste_error_handle(where, op, mdatas):
 def _paste_items(where, op, mdatas):
     logger.info('Copying a bunch of items')
     portal = api.portal.get()
-    catalog = api.portal.get_tool('portal_catalog')
     dest = portal.restrictedTraverse(str(where.lstrip('/')))
 
-    count = 0
-    commit_count = 0
     if not getCelery().conf.task_always_eager:
         portal._p_jar.sync()
 
@@ -58,7 +55,6 @@ def _paste_items(where, op, mdatas):
         pass
 
     for mdata in mdatas[:]:
-        count += len(catalog(path={'query': '/'.join(mdata), 'depth': -1}))
         ob = portal.unrestrictedTraverse(str('/'.join(mdata)), None)
         if ob is None:
             continue
@@ -68,18 +64,6 @@ def _paste_items(where, op, mdatas):
         else:
             api.content.move(ob, dest, safe_id=True)
 
-        if count / 50 != commit_count:
-            # commit every 50 objects moved
-            transaction.commit()
-            commit_count = count / 50
-            if not getCelery().conf.task_always_eager:
-                portal._p_jar.sync()
-            # so we do not redo it
-            try:
-                mdatas.remove(mdata)
-            except Exception:
-                pass
-
     # we commit here so we can trigger conflict errors before
     # trying to send email
     transaction.commit()