Make the Zipline code serving port configurable (#786)

Being locked to 8080 is not great.
cashapp · Dec 21, 2022 · 2894c43 · 2894c43
1 parent 3ace68d
commit 2894c43
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplineExtension.kt b/zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplineExtension.kt
@@ -24,6 +24,7 @@ abstract class ZiplineExtension {
   abstract val mainFunction: Property<String>
   abstract val version: Property<String>
   abstract val signingKeys: NamedDomainObjectContainer<SigningKey>
+  abstract val httpServerPort: Property<Int>
 
   abstract class SigningKey(val name: String) {
     abstract val algorithmId: Property<SignatureAlgorithmId>

diff --git a/zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplinePlugin.kt b/zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplinePlugin.kt
@@ -111,6 +111,7 @@ class ZiplinePlugin : KotlinCompilerPluginSupportPlugin {
     project.tasks.register(serveTaskName, ZiplineServeTask::class.java) { createdTask ->
       createdTask.description = "Serves Zipline files"
       createdTask.inputDir.set(ziplineCompileTask.flatMap { it.outputDir })
+      createdTask.port.set(configuration.httpServerPort)
     }
   }
 

diff --git a/zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplineServeTask.kt b/zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplineServeTask.kt
@@ -73,7 +73,7 @@ abstract class ZiplineServeTask : DefaultTask() {
           Pair("zipline", ContentType.TEXT_PLAIN)
         )
       )
-      val server = PolyHandler(http, ws).asServer(Jetty(8080))
+      val server = PolyHandler(http, ws).asServer(Jetty(port.orNull ?: 8080))
       deploymentRegistry.start(
         deploymentId,
         DeploymentRegistry.ChangeBehavior.BLOCK,