Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tablename for metadatalock name as tablename respsects both the m… #350

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Use tablename for metadatalock name as tablename respsects both the m… #350

merged 1 commit into from
Sep 27, 2024

Conversation

prudhvi
Copy link
Collaborator

@prudhvi prudhvi commented Sep 27, 2024

Fixes #347

@prudhvi
Use tablename for metadatalock name as tablename respsects both the m…
c5d093c 
…ysql table name length and MDL name length limits
@prudhvi prudhvi changed the title WIP ~ Use tablename for metadatalock name as tablename respsects both the m… Use tablename for metadatalock name as tablename respsects both the m… Sep 27, 2024
morgo
morgo approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the added test in TestResumeFromCheckpointE2EWithManualSentinel.

@morgo morgo merged commit c396803 into main Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spirit fails on metadata lock when table name is really long
2 participants
@prudhvi @morgo