prevent concurrent table modifications #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjanssen
changed the title
morgo
approved these changes
Jun 26, 2024
jayjanssen
deleted the
303-add-get_lock-to-prevent-concurrent-table-modifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbconn.MetadataLockstruct that does aGET_LOCKon a dedicated mysql connection and maintains that lock untilClose()is called or the context passed is is canceled.Runnerto take the metadata lock for the given schema + table before it starts any schema change operations to prevent concurrent Spirit runs against the same table.Close()cleans up the lock.I checked ghost and the GET_LOCK it uses does not contain the table name: https://github.com/github/gh-ost/blob/master/go/logic/applier.go#L852 so it doesn't seem like we will have any benefit to preventing simultaneous ghost and spirit runs on the same table.