Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update throttler latency query #294

Merged
merged 1 commit into from
May 30, 2024
Merged

update throttler latency query #294

merged 1 commit into from
May 30, 2024

Conversation

morgo
Copy link
Collaborator

@morgo morgo commented May 30, 2024

A Pull Request should be associated with an Issue.

Fixes #286

This updates the throttler latency query based on a previous misunderstanding:

  • We can use the MAX().. of all the applier threads as long as we use APPLYING_TRANSACTION_IMMEDIATE_COMMIT_TIMESTAMP
  • The workers not applying will return NULL for this column, so the MAX() value only considers active workers.

This can now technically return a NULL value, but it should not provided replication is enabled (which is checked in pre-flight). For simplicity though, we also wrap the final output in an IFNULL.

@morgo morgo merged commit 2bce19b into main May 30, 2024
8 checks passed
@morgo morgo deleted the mtocker-update-latency-query branch May 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'injectionless' heartbeat replication latency monitor
2 participants