Make CrossAxisAlignment modifier available for items within LazyList
#1288
Conversation
| (widget.value.parent as? FrameLayout)?.removeAllViews() | ||
| widget.value.layoutParams = layoutParams | ||
| holder.container.addView(widget.value) | ||
| widget.value.applyModifier(widget.modifier) |
There was a problem hiding this comment.
This needs to be re-applied if the modifier changes. I tried listening to changes in Items#onModifierUpdated, but it was never called on change.
There was a problem hiding this comment.
Seems like a bug! FYI @JakeWharton
veyndan
force-pushed
the
veyndan/2023-06-28/1265
branch
from
76b3d70
to
ef8332c
Compare
| @@ -25,25 +25,25 @@ import app.cash.redwood.ui.Margin | |||
| @LayoutScopeMarker | |||
| public interface LazyListScope { | |||
| public fun item( | |||
| content: @Composable () -> Unit, | |||
| content: @Composable LazyItemScope.() -> Unit, | |||
| import app.cash.redwood.layout.api.CrossAxisAlignment | ||
| import app.cash.redwood.layout.modifier.Alignment | ||
|
|
||
| internal class AlignmentImpl( |
There was a problem hiding this comment.
It's copied generated code from redwood-layout-compose. Ultimately I want to share modifier definitions with redwood-layout, so this is somewhat of a stop gap in the meantime.
veyndan
force-pushed
the
veyndan/2023-06-28/1265
branch
from
ef8332c
to
9bdec48
Compare
| public fun Modifier.alignment(alignment: CrossAxisAlignment): Modifier = | ||
| then(AlignmentImpl(alignment)) |
There was a problem hiding this comment.
@colinrtwhite Do you have any ideas on how to convert this to horizontalAlignment/verticalAlignment without introducing a new scope? LazyItemScope is used for more than just scoping modifiers (see LazyListIntervalContent), so I'm a bit hesitant to just have two separate scopes for LazyRow and LazyColumn.
Closes #1265
This only works for Android Views.