Update kscript.hcl #360
Open
Update kscript.hcl #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
approved these changes
Jul 19, 2023
|
Hmm. This is actually breaking because the older versions break on Kotlin 1.9. I'll have to be more persnickety about which versions require which versions of kotlin. Sigh. |
cgruber
force-pushed
the
cgruber-patch-1
branch
11 times, most recently
from
6faa9a9
to
8b40a92
Compare
Add in a release-candidate to the versions, since kscript breaks on kotlin-1.9 without it. Fix the version dependencies, to be more precise Older versions can't use 1.9, so target their requires statements to 1.8*
quad
reviewed
Jul 19, 2023
kscript.hcl
Outdated
| } | ||
|
|
||
| version "4.2.3-RC.1" { | ||
| requires = ["jre@17", "kotlin"] |
There was a problem hiding this comment.
Thoughts:
- Keep it as
["jre", "kotlin"]since we want the latest. - Put this at the top of the file, since it applies to all future versions. Leave the special case in the special case
versionblock.
There was a problem hiding this comment.
So... when it just had "jre" it broke in the macos build.
quad
reviewed
Jul 19, 2023
| version "4.1.1" "4.2.0" "4.2.1" "4.2.2" { | ||
| requires = ["jre@17", "kotlin-1.8.22"] | ||
| test = "kscript \"\"" // The test rig can't install older kotlin to test these, but they've been tested prior. |
There was a problem hiding this comment.
It can't install it???????????? 😱
There was a problem hiding this comment.
Well, let me rephrase - AFAICT it doesn't. I think each "test" in the foreach doesn't get its own hermit container.
|
Note, I've paused on this but I'll get back to it shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a release-candidate to the versions, since kscript breaks on kotlin-1.9 without it.