[Web Viewer] Refactor NodeLoader#load method #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when scheduling the execution of async operations
akovalev
force-pushed
the
viewer/async-queue
branch
from
76281a2 to
0561800
Compare
the nodes into multiple batches is done by NodeLoader Itself rather than its caller replace now with performance.now it was somehow lost when resolving conflicts
during the development
akovalev
force-pushed
the
viewer/async-queue
branch
from
8dd0f7c to
b7df6ad
Compare
pdubroy
reviewed
Jan 14, 2019
| @@ -18,7 +18,7 @@ The project consist of a root crate that can build and read octrees on disk and | |||
| ### Creating Octrees | |||
|
|
|||
| In the root of the repo, run `cargo build --release`. | |||
| Then use `target/release/build_octree` to generate an octree out of a PLY file. | |||
| Then use `target/release/build_octree` to generate an octree out of a PLY file (`binary_little_endian` format). Sample files can be found [here](http://www.isi.imi.i.u-tokyo.ac.jp/~rodola/data.html) | |||
| this.pendingCount = 0; | ||
| } | ||
|
|
||
| public addTask(fn: () => Promise<T>): Promise<T> { |
There was a problem hiding this comment.
I'd write this as:
public async addTask(fn: () => Promise<T>): T {
...
}
| material: THREE.ShaderMaterial, | ||
| nodes: NodeData[], | ||
| onNewNodeData: () => void | ||
| ): Promise<void[]> { |
There was a problem hiding this comment.
Is there a reason to return void[]? Assuming I understand this correctly, something like the following might be cleaner:
public async load(/* ... */) {
await Promise.all(/* ... */);
}
| @@ -325,39 +347,11 @@ export class OctreeViewer { | |||
|
|
|||
| private nodesUpdate(nodeIds: string[]) { | |||
There was a problem hiding this comment.
Prefer to write this as:
private async nodesUpdate(nodeIds: string[]) {
...
}
| if (this.batches.length == 0 || this.currentlyLoading > 2) { | ||
| return; | ||
| } | ||
| this.currentlyLoading += 1; | ||
| this.nodeLoader |
There was a problem hiding this comment.
...then you should be able to write this as:
await this.nodeLoader.load(/* ... *);
onsole.log(`nodeUpdate took ${performance.now() - start}ms.`);
the readability of APIs exposed by both OctreeViewer and AsyncTaskQueue classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Having read the code of
OctreeViewercomponent, I realised that it was pretty hard to grasp what's going on in itsnodesUpdatemethod. That's why I decided to abstract away the logic responsible for both splitting nodes into multiple batches and scheduling fetch requests so that there's no more than concurrent requests at a given moment of time intoNodeLoader#loadmethod.Implementation
In order to achieve above-mentioned goal, new class called
AsyncTaskQueuewas introduced and integrated intoNodeLoader. I believe it's better to review this PR commit by commit.Also I have slightly updated README as it took me some time to figure out how to start the web viewer's client locally.