Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated reference to cython #249

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jcohen02
Copy link
Contributor

In relation to the disucssion in #209, this PR removes a left over reference to cython that could cause confusion for learners.

@jcohen02 jcohen02 requested a review from aturner-epcc August 16, 2024 11:14
Copy link

github-actions bot commented Aug 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-249

The following changes were observed in the rendered markdown documents:

 creating-container-images.md | 3 ++-
 md5sum.txt                   | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-16 11:16:04 +0000

Copy link
Contributor

@sstevens2 sstevens2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sstevens2 sstevens2 merged commit 0367590 into carpentries-incubator:main Oct 22, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : ccd6427
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 16:21:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0367590
Branch  : main
Author  : Sarah Stevens <[email protected]>
Time    : 2024-10-22 16:21:02 +0000
Message : Merge pull request #249 from jcohen02/fix/remove-cython

Remove outdated reference to cython
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants