-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repo links in index #243
Fix repo links in index #243
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-243 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-08-04 20:26:59 +0000 |
I'm not sure what's going on here but I note that the links I've replaced here are actually defined in |
eb0c4c7
to
080bf14
Compare
An update on the previous comment - it looks like the There was also an error being generated with the link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Auto-generated via {sandpaper} Source : e631501 Branch : main Author : Andy Turner <[email protected]> Time : 2024-08-16 08:19:26 +0000 Message : Merge pull request #243 from jcohen02/fix/repo_links Fix repo links in index
Auto-generated via {sandpaper} Source : 402b978 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-08-16 08:20:16 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : e631501 Branch : main Author : Andy Turner <[email protected]> Time : 2024-08-16 08:19:26 +0000 Message : Merge pull request #243 from jcohen02/fix/repo_links Fix repo links in index
I wasn't sure if these links were left incomplete intentionally (i.e. because individuals should update them with the relevant links when they create a fork?) however, I decided it made sense to have these set to the correct locations for the reference repository.
Feel free to reject this PR if things were set up like this intentionally.