-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Workbench format #221
Port to Workbench format #221
Conversation
Something I'm not sure about. The current material has objectives in the introduction page: Lines 8 to 20 in 15b3b4f
No workbench lessons seem to do this, and indeed the workbench won't even display objectives in the intro. Not sure if I should delete these entirely? |
I've also manually now checked all the output episodes, and I'm happy with everything. Nothing seems to have been missed. |
I think they can just be moved into the main text that appears at the top of the Summary and Setup page. It is important for learners to have an overview of what they will gain from the lesson so I would not want to lose them entirely. |
Thanks for all the work on this, I will have a look through and add any comments in my review. |
Currently I have it in a |
That looks perfect! I'll go through the rest of the PR over the next day or two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review of code and rendered material looks fine. I am going to merge this in and then we can deal with any teething issues via individual fixes.
Auto-generated via {sandpaper} Source : 9150957 Branch : gh-pages Author : Andy Turner <[email protected]> Time : 2024-06-27 14:12:18 +0000 Message : Merge pull request #221 from WEHI-ResearchComputing/main Port to Workbench format
Thanks for the merge! If you could run a github pages build too, that would be great. |
I do not have permission to remove the gh-pages branch from the repo (it's existence is stopping the build from progressing as it pushes to this orphan branch). I have asked the repo admin (@sstevens2 ) to do this. If I don't not get a response soon, I will configure the build and publish to use another branch name. |
Sorry there's a blocker for your work. Just double-checking that the default branch should become main, and if so I can effect changing the default and deleting gh-pages if sstevens2 isn't available. |
Thanks @dme26 . |
I've changed the default branch to |
Auto-generated via {sandpaper} Source : 94ec900 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 14:25:25 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9150957 Branch : gh-pages Author : Andy Turner <[email protected]> Time : 2024-06-27 14:12:18 +0000 Message : Merge pull request #221 from WEHI-ResearchComputing/main Port to Workbench format
Thanks @dme26. @multimeric Deployed pages has now updated to workbench format so I think this is all working now. |
Auto-generated via {sandpaper} Source : 94ec900 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 14:25:25 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9150957 Branch : gh-pages Author : Andy Turner <[email protected]> Time : 2024-06-27 14:12:18 +0000 Message : Merge pull request #221 from WEHI-ResearchComputing/main Port to Workbench format
Hi all! Thanks so much for all your work on this! Sorry I missed it in my notifications. So excited to see this moved to the workbench! |
Auto-generated via {sandpaper} Source : 94ec900 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 14:25:25 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9150957 Branch : gh-pages Author : Andy Turner <[email protected]> Time : 2024-06-27 14:12:18 +0000 Message : Merge pull request #221 from WEHI-ResearchComputing/main Port to Workbench format
Auto-generated via {sandpaper} Source : 94ec900 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 14:25:25 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9150957 Branch : gh-pages Author : Andy Turner <[email protected]> Time : 2024-06-27 14:12:18 +0000 Message : Merge pull request #221 from WEHI-ResearchComputing/main Port to Workbench format
Auto-generated via {sandpaper} Source : 94ec900 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 14:25:25 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9150957 Branch : gh-pages Author : Andy Turner <[email protected]> Time : 2024-06-27 14:12:18 +0000 Message : Merge pull request #221 from WEHI-ResearchComputing/main Port to Workbench format
Closes #217.
You can find the rendered HTML here: https://wehi-researchcomputing.github.io/docker-introduction/.
Feedback is welcome.