[FIX]Ignore cache requests & no track incognito host Issue #15 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#15 Merge of Jolg42's work with recent evolution for Chrome + add testing.
Jolg42
previously approved these changes
Apr 14, 2020
Co-Authored-By: Joël Galeran <[email protected]>
Co-Authored-By: Joël Galeran <[email protected]>
Co-Authored-By: Joël Galeran <[email protected]>
|
Thanks for the code review @Jolg42 , code smells better like that. I played automated test to verify that everything is OK. |
|
@cguignol why this PR is closed? |
|
Because it was "Merged" somehow 🤷♂️ |
|
@Jolg42 it's the forked repo |
|
Oh yes indeed 😅 |
|
Smells like a mistake from me, I apologize and reopen the Pull Request ;) |
supertanuki
reviewed
May 13, 2020
| @@ -24,8 +24,14 @@ isChrome = () => { | |||
| }; | |||
|
|
|||
| headersReceivedListener = (requestDetails) => { | |||
| // Do not count bytes from requests from local cache | |||
| if (requestDetails.fromCache) return | |||
There was a problem hiding this comment.
?
Suggested change
| if (requestDetails.fromCache) return | |
| if (requestDetails.fromCache || requestDetails.incognito) { | |
| return; | |
| } |
And remove CONST_INCOGNITO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of Jolg42's work with recent evolution for Chrome + add testing.
Some of his work list adding "const" for the declaration of functions has not been added because of problems not solved about testability of the code.