-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starknet foundry unit testing #9
Starknet foundry unit testing #9
Conversation
run |
I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience on the review.
Some additional rework is needed.
- mint test on the token aren't needed, what we'd like to unit test is the EIP7498 methods.
- some approvals aren't needed.
- most post method call checks are missing. <-- We want to check that the logic of the redemption is working here.
- boundary checks are missing. <-- What happens when no token are left to redeem, etc.
Please try to not reuse code and import test methods you need if they exist.
Hope this is helpful.
Hi @tekkac, I've done the unit testing and resolved the issues you raised. |
I'm closing this one as it has been superseded by the current Seaport issues. |
This is the implementation of Starknet foundry unit testing using snforge