use bulk copy methods to initialize writable text and data defaults

capnproto · Oct 23, 2024 · b2f7242 · b2f7242
1 parent cfea947
commit b2f7242
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/runtime/src/main/java/org/capnproto/WireHelpers.java b/runtime/src/main/java/org/capnproto/WireHelpers.java
@@ -802,10 +802,12 @@ static Text.Builder getWritableTextPointer(int refOffset,
                 return new Text.Builder();
             } else {
                 Text.Builder builder = initTextPointer(refOffset, segment, defaultSize);
-                // TODO is there a way to do this with bulk methods?
-                for (int i = 0; i < builder.size; ++i) {
-                    builder.buffer.put(builder.offset + i, defaultBuffer.get(defaultOffset * 8 + i));
-                }
+
+                ByteBuffer slice = defaultBuffer.duplicate();
+                slice.position(defaultOffset * 8);
+                slice.limit(defaultOffset * 8 + defaultSize);
+                builder.buffer.position(builder.offset);
+                builder.buffer.put(slice);
                 return builder;
             }
         }
@@ -872,10 +874,12 @@ static Data.Builder getWritableDataPointer(int refOffset,
                 return new Data.Builder();
             } else {
                 Data.Builder builder = initDataPointer(refOffset, segment, defaultSize);
-                // TODO is there a way to do this with bulk methods?
-                for (int i = 0; i < builder.size; ++i) {
-                    builder.buffer.put(builder.offset + i, defaultBuffer.get(defaultOffset * 8 + i));
-                }
+
+                ByteBuffer slice = defaultBuffer.duplicate();
+                slice.position(defaultOffset * 8);
+                slice.limit(defaultOffset * 8 + defaultSize);
+                builder.buffer.position(builder.offset);
+                builder.buffer.put(slice);
                 return builder;
             }
         }