Ignore redundant nesting when checking for related siblings #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the best candidate is in an element all by itself, then we should
probably check its nearest ancestor that has siblings when considering
whether to append siblings that meet the score threshold.
For example, in the example below, we would now include the second
paragraph whereas previous we would not.
```html
<div>
<div>
<p>This is the best candidate.</p>
</div>
</div>
<p>This paragraph meets the score threshold.</p>
```
|
Hi @tuzz! Does the Mozilla JS version do this? For consistency we should probably make this an option. |
|
Hi @cantino, apologies for the slow reply. No, the Mozilla JS version doesn't have this feature. I've just pushed a commit to hide it behind an option. Hopefully the feature is useful enough to be considered for inclusion. We've found it really helps for some DOM structures. Thanks |
|
Thanks @tuzz! |
|
Releases in 0.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the best candidate is in an element all by itself, then we should probably check its nearest ancestor that has siblings when considering whether to append siblings that meet the score threshold.
For example, in the example below, we would now include the second paragraph whereas previous we would not.
Note that this changes behaviour. We could put this change behind an option if preferred. I think this will improve the extraction for most use cases, though, and none of the existing test cases fail.