Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue with pack #25

Closed
wants to merge 2 commits into from
Closed

fix: Fixes issue with pack #25

wants to merge 2 commits into from

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Jan 17, 2024

Description

There's an issue with rockcraft 1.1.0 preventing rocks with chiseled packages from packing. Here we wanted to validate that Rockcraft 1.1.1 fixes this issue. Do not merge this PR, I want to avoid having to maintain snap revisions in all of our Rock's CI's.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume closed this Jan 17, 2024
@gruyaume gruyaume deleted the dev-bugfix branch April 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant