Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Runs workflow on PR #10

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore: Runs workflow on PR #10

merged 1 commit into from
Oct 9, 2023

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Oct 9, 2023

Description

This PR made me realise that workflows don't run if the change comes from a fork of the project. This PR makes it so that workflows run on PR's and pushes to main.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume requested a review from a team as a code owner October 9, 2023 12:10
@gruyaume gruyaume merged commit 1036059 into main Oct 9, 2023
5 checks passed
@gruyaume gruyaume deleted the dev-workflow branch October 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruyaume @gatici