-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand certified configuration search result pages #14381
base: main
Are you sure you want to change the base?
Rebrand certified configuration search result pages #14381
Conversation
andrejvelichkovski is not a collaborator of the repo |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14381 +/- ##
==========================================
+ Coverage 69.58% 69.64% +0.05%
==========================================
Files 120 120
Lines 3419 3419
Branches 1178 1174 -4
==========================================
+ Hits 2379 2381 +2
+ Misses 1015 1013 -2
Partials 25 25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note: this page is not new, it is a copy of the filters that were previously defined in both category-search-results.html
and search-results.html
. I moved them to this file and reused them instead of defining them in both places.
Done
This PR rebrands the search pages under ubuntu.com/certified.
Change structure
To help with the review, please check out the description of the changes below.
Firstly, we need to define what are all the pages that allow users to search for hardware. Currently we have three different search page types:
/certified/laptops
(ubuntu.com/certified/laptops)/certified/desktops
(ubuntu.com/certified/desktops)/certified/iot
(ubuntu.com/certified/iot)/certified/servers
(ubuntu.com/certified/servers)/certified/socs
(ubuntu.com/certified/socs)/certified/vendor/HP
(ubuntu.com/certified/HP) (and a few other vendors)Previously, the generic search results page was fully separately defined in the
search-results.html
template, while the other functionalities shared the same search results table. I have now moved all functionalities to share the same search results table to avoid code duplication.All search result templates have the same file structure (such files are
search-results.html
,laptops.html
,servers.html
,desktops.html
,devices.html
,socs.html
andvendors/vendor.html
):The hardware results block contains a few small files to break them down. I have made this change to make them easier to review. Below is a hierarchy of the file structure:
QA
./run serve
ordotrun
Issue / Card
Fixes #
Screenshots
Generic search results
Laptops
Desktops
IoT
Servers
System on Chip (SoC)
Vendor
Help
QA steps - Commit guidelines