Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand certified configuration search result pages #14381

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andrejvelichkovski
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski commented Oct 2, 2024

Done

This PR rebrands the search pages under ubuntu.com/certified.

Change structure

To help with the review, please check out the description of the changes below.

Firstly, we need to define what are all the pages that allow users to search for hardware. Currently we have three different search page types:

  • generic search results page, leads if you go to ubuntu.com/certified?q=Dell
  • category search pages:
    • /certified/laptops (ubuntu.com/certified/laptops)
    • /certified/desktops (ubuntu.com/certified/desktops)
    • /certified/iot (ubuntu.com/certified/iot)
    • /certified/servers (ubuntu.com/certified/servers)
    • /certified/socs (ubuntu.com/certified/socs)
  • vendor search pages: under: /certified/vendor/HP (ubuntu.com/certified/HP) (and a few other vendors)

Previously, the generic search results page was fully separately defined in the search-results.html template, while the other functionalities shared the same search results table. I have now moved all functionalities to share the same search results table to avoid code duplication.

All search result templates have the same file structure (such files are search-results.html, laptops.html, servers.html, desktops.html, devices.html, socs.html and vendors/vendor.html):

  1. Hero section (different for each search page)
  2. Horizontal line
  3. Hardware results shown in a table

The hardware results block contains a few small files to break them down. I have made this change to make them easier to review. Below is a hierarchy of the file structure:
Screenshot from 2024-11-04 15-14-07

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • [List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes #

Screenshots

Generic search results

Screenshot from 2024-11-04 15-23-43

Laptops

Screenshot from 2024-11-04 15-23-58

Desktops

Screenshot from 2024-11-04 15-24-18

IoT

Screenshot from 2024-11-04 15-25-10

Servers

Screenshot from 2024-11-04 15-25-36

System on Chip (SoC)

Screenshot from 2024-11-04 15-25-23

Vendor

image

Help

QA steps - Commit guidelines

@webteam-app
Copy link

andrejvelichkovski is not a collaborator of the repo

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (9e30eb1) to head (a811b2a).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14381      +/-   ##
==========================================
+ Coverage   69.58%   69.64%   +0.05%     
==========================================
  Files         120      120              
  Lines        3419     3419              
  Branches     1178     1174       -4     
==========================================
+ Hits         2379     2381       +2     
+ Misses       1015     1013       -2     
  Partials       25       25              

see 1 file with indirect coverage changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note: this page is not new, it is a copy of the filters that were previously defined in both category-search-results.html and search-results.html. I moved them to this file and reused them instead of defining them in both places.

@andrejvelichkovski andrejvelichkovski marked this pull request as ready for review November 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants