Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbm-kms: Make cursor transitions across outputs smoother #3451

Merged

Conversation

ehopperdietzel
Copy link
Contributor

Keep hardware cursor planes visible on all outputs intersected by the cursor geometry instead of only its position.

Issue: #3449

Keep hardware cursor planes visible on all outputs intersected by the cursor geometry instead of only its position
@ehopperdietzel ehopperdietzel requested a review from a team as a code owner June 27, 2024 18:58
@RAOF
Copy link
Contributor

RAOF commented Jun 28, 2024

Oh, yeah. This seems like a good idea.

This change introduces a test failure in MesaCursorTest.move_to_moves_cursor_to_right_output (presumably because the behaviour is now that the cursor is on both outputs, because it spans both outputs). Would you like to fix that up so I can approve this?

@ehopperdietzel
Copy link
Contributor Author

Sure, no problem

@ehopperdietzel
Copy link
Contributor Author

presumably because the behaviour is now that the cursor is on both outputs, because it spans both outputs

Exactly, the test outputs are too small hahaha, but now it should be fixed.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (0980da3) to head (ddb613c).
Report is 407 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
- Coverage   77.24%   77.23%   -0.01%     
==========================================
  Files        1071     1071              
  Lines       68467    68468       +1     
==========================================
- Hits        52886    52884       -2     
- Misses      15581    15584       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanGriffiths AlanGriffiths self-requested a review June 28, 2024 11:12
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jun 28, 2024
Merged via the queue into canonical:main with commit a994779 Jun 28, 2024
21 of 23 checks passed
@ehopperdietzel ehopperdietzel deleted the gbm_kms_output_cursor_transition branch June 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants