Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: screenshots now respect the GLConfig and contain a depth + stencil buffer when one is required #3444

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Jun 25, 2024

fixes #3438

What's new?

  • BasicScreenShooter now respects the GLConfig
  • When depth and stencil bits are provided, we create a render buffer for them

I was unable to make separate stencil/depth buffers worked, but it is apparently recommended that they are combined. I don't know if this will have any major issues...

@mattkae mattkae requested a review from RAOF June 25, 2024 19:13
@mattkae mattkae marked this pull request as ready for review June 25, 2024 19:13
@mattkae mattkae requested a review from a team as a code owner June 25, 2024 19:13
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.23%. Comparing base (b526b15) to head (b486ad8).
Report is 423 commits behind head on main.

Files with missing lines Patch % Lines
...latforms/common/server/cpu_copy_output_surface.cpp 0.00% 10 Missing ⚠️
...latforms/eglstream-kms/server/buffer_allocator.cpp 0.00% 1 Missing ⚠️
src/platforms/gbm-kms/server/buffer_allocator.cpp 0.00% 1 Missing ⚠️
...latforms/renderer-generic-egl/buffer_allocator.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3444      +/-   ##
==========================================
- Coverage   77.24%   77.23%   -0.01%     
==========================================
  Files        1071     1071              
  Lines       68468    68475       +7     
==========================================
- Hits        52890    52889       -1     
- Misses      15578    15586       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible, and doesn't break anything I tried

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 317060e Jul 1, 2024
30 of 43 checks passed
@AlanGriffiths AlanGriffiths deleted the bugfix/screenshot_depth_bits branch July 1, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicScreenShooter should have a configurable GLConfig
2 participants