-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add Mir's CI documentation #3434
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3434 +/- ##
==========================================
- Coverage 77.24% 77.23% -0.01%
==========================================
Files 1071 1071
Lines 68468 68467 -1
==========================================
- Hits 52890 52883 -7
- Misses 15578 15584 +6 ☔ View full report in Codecov by Sentry. |
224cc17
to
89b7cbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions 😄
The content mostly makes sense to me
- set the stage better - better wording all around - use "merge" rather than "push", since we require that for `main` and `release/` - clarify ubsan Co-Authored-By: Matthew Kosarek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good by me!
No description provided.