More better names

[AlanGriffiths]

No description provided.

[RAOF]

I have a weak preference for DisplaySink over DisplayDevice, as my feeling is “Sink” is more aligned with the domain terminology, but DisplayDevice is definitely an improvement.

[AlanGriffiths]

I have a weak preference for DisplaySink over DisplayDevice

I started out with DisplaySink but, as I looked at the surrounding code, I changed my mind.

@Saviq @mattkae - time to pile in with additional opinions

[codecov]

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (47d782f) 77.82% compared to head (077a804) 77.82%.

Files	Patch %	Lines
src/platforms/x11/graphics/display_sink.cpp	28.57%	10 Missing ⚠️
...latforms/eglstream-kms/server/buffer_allocator.cpp	0.00%	7 Missing ⚠️
src/platforms/gbm-kms/server/buffer_allocator.cpp	0.00%	7 Missing ⚠️
src/platforms/eglstream-kms/server/display.cpp	0.00%	5 Missing ⚠️
src/platforms/gbm-kms/server/kms/display.cpp	55.55%	4 Missing ⚠️
...rc/platforms/gbm-kms/server/kms/display_buffer.cpp	77.77%	4 Missing ⚠️
src/platforms/x11/graphics/display.cpp	57.14%	3 Missing ⚠️
...latforms/renderer-generic-egl/buffer_allocator.cpp	83.33%	1 Missing ⚠️
...include/mir/test/doubles/null_display_sync_group.h	50.00%	1 Missing ⚠️
tests/include/mir/test/doubles/stub_display_sink.h	50.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3123   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files        1074     1074           
  Lines       74862    74864    +2     
=======================================
+ Hits        58261    58264    +3     
+ Misses      16601    16600    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattkae]

Some nits, but it is what I expected

[Saviq]

I'm not going to help a lot, but I have no strong preference between DisplaySink and DisplayDevice.

My only concern with Device would be the potential for ambiguity. But that can be improved by means of documentation.

[AlanGriffiths]

My only concern with Device would be the potential for ambiguity. But that can be improved by means of documentation.

If DisplaySink is less prone to ambiguity, I think that's the better approach. (I just found it overly generic)

[Saviq]

If DisplaySink is less prone to ambiguity, I think that's the better approach. (I just found it overly generic)

I do think it is, I can think of multiple devices (DRM, input, hardware…) that we already deal with. But if Sink isn't right, either - maybe we need to come up with something else again. We do sink renderables into it, though, so 🤷.

[mattkae]

I cannot think of anything better than sink, so I am happy

[Saviq]

Just a couple whitespace nits from me.

Feel free to merge when done.