[mir:virtual] drop GenericEGLDisplayProvider #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlanGriffiths you got some stray commits in here |
AlanGriffiths
force-pushed
the
drop-GenericEGLDisplayProvider-from-virtual-platform
branch
from
454a8f3 to
54c2ed1
Compare
Fixed, thanks |
|
Need to reverse / drop a few tests: |
Codecov Report
@@ Coverage Diff @@
## allow-llvmpipe-rendering #3100 +/- ##
============================================================
+ Coverage 78.31% 78.40% +0.09%
============================================================
Files 1074 1073 -1
Lines 74827 74717 -110
============================================================
- Hits 58602 58584 -18
+ Misses 16225 16133 -92
... and 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mattkae
approved these changes
Oct 26, 2023
mattkae
deleted the
drop-GenericEGLDisplayProvider-from-virtual-platform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need it anymore