Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphics: drop MIR_EXPERIMENTAL_HYBRID_GRAPHICS and use the virtual platform in CI #3099

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Oct 26, 2023

No description provided.

@Saviq Saviq force-pushed the all-hybrid-virtual branch from 381a840 to 7fa1358 Compare October 26, 2023 08:51
@Saviq
Copy link
Collaborator Author

Saviq commented Oct 26, 2023

Base automatically changed from allow-llvmpipe-rendering to main October 27, 2023 05:34
@AlanGriffiths
Copy link
Collaborator

* [The compositor report doesn't work on the virtual platform #3101](https://github.com/MirServer/mir/issues/3101)

I think we can drop this test, it isn't relevant anymore

@Saviq
Copy link
Collaborator Author

Saviq commented Oct 27, 2023

I think we can drop this test, it isn't relevant anymore

Well, it's as relevant as it was before? Just not on the virtual platform? :)

Would still be good to run it to include its coverage, but yeah that's not a priority.

@Saviq Saviq force-pushed the all-hybrid-virtual branch from 05d1305 to f22e141 Compare October 27, 2023 08:39
@AlanGriffiths
Copy link
Collaborator

Well, it's as relevant as it was before? Just not on the virtual platform? :)

It checks that we don't exhaust the frontend thread pool by starting "many" clients. That hasn't been since we dropped mirclient (and not actually possible for a long time before that).

@Saviq Saviq force-pushed the all-hybrid-virtual branch 3 times, most recently from f9b9f98 to 969a6bf Compare October 27, 2023 18:00
@Saviq Saviq changed the base branch from main to bugfix/3102 October 27, 2023 18:01
@Saviq Saviq force-pushed the all-hybrid-virtual branch from 969a6bf to e81a5e1 Compare October 27, 2023 18:21
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3099 (0e1a786) into bugfix/3102 (389033c) will decrease coverage by 0.53%.
Report is 1 commits behind head on bugfix/3102.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           bugfix/3102    #3099      +/-   ##
===============================================
- Coverage        78.32%   77.80%   -0.53%     
===============================================
  Files             1074     1064      -10     
  Lines            74793    74359     -434     
===============================================
- Hits             58583    57853     -730     
- Misses           16210    16506     +296     
Files Coverage Δ
src/server/graphics/default_configuration.cpp 79.73% <ø> (-1.02%) ⬇️

... and 50 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Saviq Saviq marked this pull request as ready for review October 27, 2023 19:09
@Saviq Saviq requested a review from RAOF October 27, 2023 19:09
@Saviq Saviq force-pushed the all-hybrid-virtual branch from e81a5e1 to 0e1a786 Compare October 28, 2023 07:40
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No known blockers now

@AlanGriffiths AlanGriffiths merged commit 7e5590c into bugfix/3102 Oct 30, 2023
24 of 33 checks passed
@AlanGriffiths AlanGriffiths deleted the all-hybrid-virtual branch October 30, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants