Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing of --platform-*-libs #3090

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

AlanGriffiths
Copy link
Collaborator

Fixes: #3088

@AlanGriffiths AlanGriffiths requested a review from Saviq October 24, 2023 10:06
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #3090 (c539fb4) into main (9404475) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3090      +/-   ##
==========================================
- Coverage   78.45%   78.44%   -0.01%     
==========================================
  Files        1064     1064              
  Lines       74434    74431       -3     
==========================================
- Hits        58394    58390       -4     
- Misses      16040    16041       +1     
Files Coverage Δ
src/server/graphics/default_configuration.cpp 80.75% <100.00%> (-0.24%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yups.

I was tempted to talk about ordering, but that would be papering over things we need to fix.

@Saviq Saviq added this pull request to the merge queue Oct 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2023
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 60a5409 Oct 25, 2023
21 checks passed
@AlanGriffiths AlanGriffiths deleted the fix-plarform-XXX-libs-parsing branch October 25, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--platform-*-libs chokes on comma-separated list
2 participants