Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get started: Remove 'enable istio' (now in community repos) (fixes #634) #635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thp-canonical
Copy link

Done

Remove microk8s enable istio from the instructions, because it depends on community repositories

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8027/
  • Run through the following QA steps
  • The microk8s enable istio item in step 3. of the getting started guide has been removed for Linux, macOS and Windows

Issue / Card

Fixes #634

@webteam-app
Copy link

Demo starting at https://microk8s-io-635.demos.haus

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (b9ee7b2) to head (2bad8a0).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files           2        2           
  Lines          74       74           
=======================================
  Hits           62       62           
  Misses         12       12           
Flag Coverage Δ
python 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@divineforge divineforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a value change to the documentation. worth merging it, otherwise creating some 'unhelpful situation' to beginners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"microk8s enable istio" in Get started guide results in an error
3 participants