Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #2015

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: update dependencies #2015

merged 1 commit into from
Oct 21, 2024

Conversation

abbiesims
Copy link
Contributor

@abbiesims abbiesims commented Oct 21, 2024 •
edited
Loading

Done

  • Updates dependency issues (mainly Vanilla and store-component conflicts)
  • There are now some Sass deprecation warnings related to the new Vanilla version, but for now, no content is affected

How to QA

  • All tests pass
  • Click around the demo and make sure everything looks as expected

Testing

  • This PR has tests
  • No testing required (explain why): no behavioural change

@webteam-app
Copy link

Demo

Jenkins

demos.haus

M7mdisk
M7mdisk approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@M7mdisk M7mdisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, are the warnings caused by vanilla?

@abbiesims
Copy link
Contributor Author

👍 looks good, are the warnings caused by vanilla?

Yep, it's with the sass upgrade that goes along with the new version of vanilla

@abbiesims abbiesims merged commit 9437470 into main Oct 21, 2024
13 checks passed
@abbiesims abbiesims deleted the chore/update-deps branch October 21, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M7mdisk M7mdisk M7mdisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abbiesims @webteam-app @M7mdisk