Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for interfaces view #1768

Merged
merged 8 commits into from
Nov 8, 2024

Conversation

codeEmpress1
Copy link
Contributor

Done

  • Add tests for interfaces view

How to QA

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://charmhub-io-1768.demos.haus

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.10%. Comparing base (a81444a) to head (b9845f9).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
+ Coverage   53.87%   57.10%   +3.23%     
==========================================
  Files          30       32       +2     
  Lines        2246     2280      +34     
==========================================
+ Hits         1210     1302      +92     
+ Misses       1036      978      -58     
Files with missing lines Coverage Δ
tests/interfaces/test_single_interface.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@codeEmpress1 codeEmpress1 merged commit 8cd8170 into canonical:main Nov 8, 2024
13 checks passed
@codeEmpress1 codeEmpress1 deleted the test-interfaces branch November 8, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants