Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Fix tag version for GPU image #102

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Aug 7, 2024

We have noticed that the GPU tag does not use the tag versioning we have for jupyter and kyuubi. I have update this.

Also while doing this, I changed the FLAVOUR for gpu support from spark-gpu to gpu which obeys less is more principle, and it seems a bit more consistent with the other flavours that we have, like naming charmed-spark-{flavour} the images

Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deusebio deusebio merged commit 89eeff5 into 3.5-22.04/edge Aug 14, 2024
14 checks passed
@deusebio deusebio deleted the wip-fix-gpu-version branch August 14, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants