feat(web-modeler): configure JWK Set URI for restapi component #2704
+676
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
version/8.5
jfriedenstab
force-pushed
the
web-modeler-11510-jwk-set-uri
branch
from
52352c3 to
6a9b707
Compare
jfriedenstab
force-pushed
the
web-modeler-11510-jwk-set-uri
branch
from
6a9b707 to
b76bb88
Compare
jfriedenstab
force-pushed
the
web-modeler-11510-jwk-set-uri
branch
from
b76bb88 to
3d41864
Compare
jfriedenstab
force-pushed
the
web-modeler-11510-jwk-set-uri
branch
from
3d41864 to
e62cb5e
Compare
jfriedenstab
commented
Jan 8, 2025
There was a problem hiding this comment.
I noticed that there was no golden file for configmap-restapi yet and used the opportunity to add it. This will also test the default value for jwk-set-uri.
jfriedenstab
commented
Jan 8, 2025
Comment on lines
+29
to
+30
| "global.identity.auth.connectors.existingSecret.name": "foo", | ||
| "global.identity.auth.core.existingSecret.name": "foo", |
There was a problem hiding this comment.
These values are required now given that global.testDeprecationFlags.existingSecretsMustBeSet was changed from warning to error. I think they're missing in all of the unit tests. At least, I added them here to be able to run the (new) tests for the restapi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Closes https://github.com/camunda/web-modeler/issues/11510
What's in this PR?
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: