Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to PNG of a diagram with webhook connector fails #4127

Closed
barmac opened this issue Feb 12, 2024 · 13 comments · May be fixed by #4569
Closed

Export to PNG of a diagram with webhook connector fails #4127

barmac opened this issue Feb 12, 2024 · 13 comments · May be fixed by #4569
Assignees
Labels
bug Something isn't working element templates export good first issue Good for newcomers
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 12, 2024

Describe the bug

In Camunda Modeler 5.20.0, the attached BPMN fails to export to PNG, and an error is printed:

This page contains the following errors:error on line 1 at column 723: Unescaped '<' not allowed in attributes values
Below is a rendering of the page up to the first error. [ ERROR ]

insurance.bpmn.txt

When I remove the event with custom icon, it exports correctly.

Steps to reproduce

  1. Open the attached BPMN
  2. Try to export to PNG
  3. now this happens

Expected behavior

It should export.

Environment

  • OS: MacOS
  • Camunda Modeler Version: 5.20.0
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@barmac barmac added the bug Something isn't working label Feb 12, 2024
@nikku
Copy link
Member

nikku commented Feb 13, 2024

This works with all but the webhook connector icon, cf. test diagram.

Hence I think there may be something wrong with the webhook connector icon. Let's update the scope of this issue accordingly.

@barmac
Copy link
Collaborator Author

barmac commented Feb 13, 2024

Right, it works with the diagram you provided. I will update the issue accordingly.

@barmac barmac changed the title Export to PNG of a diagram with custom event icon fails Export to PNG of a diagram with webhook connector fails Feb 13, 2024
@nikku nikku added the good first issue Good for newcomers label Apr 8, 2024
@SamanthaHolstine
Copy link

Had a community member facing the same issue, printing the same error. Forum question here. The forum question includes the diagram having issues.

@NPDeehan
Copy link

Hey folks, is there any update on this?

@barmac
Copy link
Collaborator Author

barmac commented Sep 20, 2024

I can still reproduce it in both 5.27 and the current nightly, so this is not going to be fixed in the upcoming release. Is this reported often? Any other reason we should prioritize this?

@NPDeehan
Copy link

It comes up fairly frequently and it's a very common feature for business users to come across.

@barmac
Copy link
Collaborator Author

barmac commented Sep 20, 2024

Thanks, I'll move it to ready to discuss in the upcoming iteration planning.

@barmac barmac added ready Ready to be worked on and removed backlog Queued in backlog labels Sep 20, 2024
@barmac
Copy link
Collaborator Author

barmac commented Sep 20, 2024

@barmac barmac self-assigned this Sep 24, 2024
barmac added a commit that referenced this issue Sep 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Sep 30, 2024
@barmac
Copy link
Collaborator Author

barmac commented Sep 30, 2024

I just checked if we can drop canvg and thus fix this issue, but it's not enough: #4569

@barmac barmac added backlog Queued in backlog and removed in progress Currently worked on labels Sep 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Sep 30, 2024
@barmac
Copy link
Collaborator Author

barmac commented Oct 1, 2024

So this issue goes all the way up to tiny-svg: bpmn-io/tiny-svg#16
Once we fix it there and integrate in the dependencies, the issue will be fixed.

@nikku
Copy link
Member

nikku commented Oct 1, 2024

Bug here.

@barmac barmac added the fixed upstream Requires integration of upstream change label Oct 1, 2024 — with bpmn-io-tasks
@barmac barmac removed the in progress Currently worked on label Oct 1, 2024
barmac added a commit that referenced this issue Oct 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Oct 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 1, 2024
@barmac
Copy link
Collaborator Author

barmac commented Oct 1, 2024

Fixed upstream via bpmn-io/tiny-svg#17, and will be closed via #4576

nikku pushed a commit that referenced this issue Oct 1, 2024
nikku pushed a commit that referenced this issue Oct 1, 2024
@nikku
Copy link
Member

nikku commented Oct 1, 2024

Closed via #4576

@nikku nikku closed this as completed Oct 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 1, 2024
@github-actions github-actions bot added this to the M82 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working element templates export good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants