Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

innerSVG does not escape < and > in attributes #16

Closed
barmac opened this issue Oct 1, 2024 · 1 comment · Fixed by #17
Closed

innerSVG does not escape < and > in attributes #16

barmac opened this issue Oct 1, 2024 · 1 comment · Fixed by #17
Assignees
@barmac
Labels
bug

Comments

@barmac
Copy link
Member

barmac commented Oct 1, 2024 •
edited
Loading

Describe the Bug

The innerSVG(svg) helper does not escape the attributes which leads to broken SVG.

Steps to Reproduce

Cf. the test case in 83cd6a2

Expected Behavior

The characters should be transformed into &gt; and &lt;.

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]

Related to camunda/camunda-modeler#4127
@barmac barmac added the bug label Oct 1, 2024
@barmac barmac mentioned this issue Oct 1, 2024
Closed
@nikku
Copy link
Member

nikku commented Oct 1, 2024

Bug here

barmac added a commit that referenced this issue Oct 1, 2024
@barmac
fix: escape entities in attributes
8463b4b 
Closes #16
@barmac barmac mentioned this issue Oct 1, 2024
Merged
4 tasks
@nikku nikku closed this as completed in #17 Oct 1, 2024
@nikku nikku closed this as completed in 4cb2f5d Oct 1, 2024
barmac added a commit that referenced this issue Oct 1, 2024
@barmac
fix: escape entities in attributes (#17)
0726866 
Closes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: escape entities in attributes bpmn-io/tiny-svg
2 participants
@nikku @barmac