Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fidelity contributions final repo comments apis #4565

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fidelity contributions final repo comments apis #4565

wants to merge 1 commit into from
+3,084 −67

Conversation

yanavasileva
Copy link
Member

No description provided.

@yanavasileva yanavasileva added the ci:no-build Prevents any CI stage from running. label Aug 28, 2024
@yanavasileva yanavasileva self-assigned this Aug 28, 2024
@yanavasileva yanavasileva added ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. and removed ci:no-build Prevents any CI stage from running. labels Aug 29, 2024
@yanavasileva yanavasileva mentioned this pull request Aug 30, 2024
Open
@yanavasileva yanavasileva added the ci:all-db Runs the builds for all databases. label Sep 20, 2024
@prajwolbhandari1 @yanavasileva
feat(engine) Add update and delete Java/Rest APIs of task and
b07e214 
processInstance

DELETE /task/{taskId}/comment/{commentId}
  - deletes a comment of a given taskId and commentId
DELETE /task/{taskId}/comment
  - deletes all comments of a given taskId
PUT /task/comment
  - updates a comment
DELETE /process-instance/{processInstanceId}/comment/{commentId}
 - deletes a comment of a given processInstanceId and commentId
DELETE /process-instance/{processInstanceId}/comment.
 - deletes all comments of a given processInstanceId
PUT /process-instance/comment
 - updates a comment

related to: #2551

feat(engine-rest-core) Add update and delete Java/Rest APIs of task and
processInstance

feat(engine-rest-openapi) Add update and delete Java/Rest APIs of task
and processInstance

feat(engine)
- add revision to comments
- change authorization to task_assign from task_update
- refactor code
- add more java docs

feat(engine) update task_assign authorization to task_work for
delete/update comments

Feedback Adjustments
- fix verbiage in ftl files
- add standalone tests for delete comment(s) by process instance id and
task id
- fix/rewrite sql statement
- write additional process instance tests
- few minor changes

Fix engine-rest tests
@yanavasileva yanavasileva added ci:all-as Runs the builds for all application servers. ci:webapp-integration Runs the webapp integration builds. labels Nov 15, 2024
@yanavasileva yanavasileva force-pushed the fidelity-contributions-finalRepoCommentsApis branch from 0878e62 to b07e214 Compare November 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yanavasileva yanavasileva

Labels
ci:all-as Runs the builds for all application servers. ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanavasileva @prajwolbhandari1