Executable bit set on script folders #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anyone tending to PRs? @simahawk or @i-vyshnevska ? |
| @@ -30,7 +30,8 @@ on_exit() { | |||
| } | |||
|
|
|||
| trap on_exit EXIT | |||
|
|
|||
| # as executable bit will be inherited to the docker image we explicitly set executable bit on scripts | |||
| chmod -R +x start-entrypoint.d/ before-migrate-entrypoint.d/ | |||
There was a problem hiding this comment.
I am not sure this change is needed, maybe @p-tombez give a point
p-tombez
reviewed
Aug 30, 2021
There was a problem hiding this comment.
I don't see the utility of this change for several reasons :
- Assuming one of the files in the directories doesn't have the execute bit on, the script will change it and git will detect it, thus making the local repository in a stale state (so the local repo is not anymore a source of truth)
- If anyone make a PR to add a script and forget to add
+xon it, the Travis build will fail and that person would have to fix it before it is merged - These images are intended to be inherited before being used. This fix will not prevent a failure if anyone add a script in these folders without
+x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @pniederlag 's PR (GH-90) that fixes #89.
He only missed a parameter from
chmod. If it's easier to fix and merge that then do it. My goal is to make it work.