Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Footer Not Present on info page Issue #1064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulptl165
Copy link

Fixes #1061 by @ishaanxgupta
Fix footer rendering issue by relocating the insertFooterLayout() script.

Summary

The insertFooterLayout() script was initially placed just below the id="footer-layout" element, causing the function to fail as the DOM was not fully loaded. The script was relocated to the end of the body tag, ensuring the DOM is fully loaded before executing the function.

Before Fix

  • The footer content was not rendered correctly when the script was placed immediately after the footer-layout element.

After Fix

  • The footer content now renders as expected since the script executes after the entire DOM is loaded.

Motivation

This pull request addresses an issue with the footer not being correctly inserted into the footer-layout element due to the script running prematurely. Moving the script ensures reliable and consistent footer rendering on info page.

Testing

Screenshot 2025-01-09 220202
Screenshot (848)

  • Manually tested the fix on info page in the application to confirm that the footer renders correctly in all cases.
  • Verified that other scripts and components were unaffected by this change.
  • Ensured the change follows best practices for script placement to avoid potential future issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer not present in Info Tab
1 participant