Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes:#912 W3C standards for the landing.html file #1044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ujjwaldubey1
Copy link

Pull Request for Fixing W3C Standards in landing.html

Summary

This PR addresses W3C compliance issues in the landing.html file of the caMicroscope application. Changes include:

Adding the lang attribute to the tag for better accessibility.
Adding a proper DOCTYPE declaration for HTML5 compliance.
Ensuring all tags have appropriate alt attributes.
Removing deprecated attributes like frameborder from <iframe> elements.
Enhancing the semantic structure by using ARIA roles where necessary.
Fixing minor indentation and structure issues for better readability.

Motivation

Testing

Verified HTML structure using the W3C Markup Validation Service.
Manual testing performed in:
Google Chrome (latest version)
Mozilla Firefox (latest version)
Microsoft Edge (latest version)
Ensured that all changes did not impact the visual layout or existing functionality of the page.

Questions

1.Are there any additional attributes or roles you'd recommend for enhanced accessibility?
2.Should we implement automated W3C validation checks as part of our CI/CD pipeline?

@ujjwaldubey1 ujjwaldubey1 changed the title FIX W3C standards for the landing.html file FIX W3C standards for the landing.html file Nov 16, 2024
@ujjwaldubey1 ujjwaldubey1 changed the title FIX W3C standards for the landing.html file Fixes:#912 W3C standards for the landing.html file Nov 16, 2024
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Dec 19, 2024
@birm birm removed the Stale label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants