-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build on windows #23
Conversation
Hey @cameron-martin, would like help on this one? |
Yes please. I believe the problem is that paths of certain files in the runfiles tree exceed the 260 character limit imposed by Windows. I fixed this for the rules_rust bzlmod examples in bazelbuild/rules_rust#2454 by shortening various components of the path, but for some reason the paths here are still exceeding this limit. I'm yet to work out why this is, so help is very much appreciated. |
Added commit to fix failing tests under windows in #55, feel free to cherry-pick that commit to this PR or close the other PR if not useful. |
This breaks rust-analyzer support otherwise
Thanks. I've added your commit to this PR since I had to fix a rust-analyzer issue too. I'll close your PR, but thanks for fixing this issue! |
Could you also add Or is it possible to make the buildbuddy links public / accessible (I guess it would should errors for tests as well). I am getting |
I believe this issue is fixed now, but I've enabled a setting that should make builds public in #58. |
This requires a few hacks to avoid hitting the Windows path limit, plus a few generalisations around path names and usage of platform-specific extension traits.