Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build on windows #23

Merged
merged 24 commits into from
Nov 25, 2024
Merged

ci: Build on windows #23

merged 24 commits into from
Nov 25, 2024

Conversation

cameron-martin
Copy link
Owner

@cameron-martin cameron-martin commented Feb 23, 2024

This requires a few hacks to avoid hitting the Windows path limit, plus a few generalisations around path names and usage of platform-specific extension traits.

@albertocavalcante
Copy link
Contributor

Hey @cameron-martin, would like help on this one?

@cameron-martin
Copy link
Owner Author

cameron-martin commented Aug 1, 2024

Yes please. I believe the problem is that paths of certain files in the runfiles tree exceed the 260 character limit imposed by Windows. I fixed this for the rules_rust bzlmod examples in bazelbuild/rules_rust#2454 by shortening various components of the path, but for some reason the paths here are still exceeding this limit. I'm yet to work out why this is, so help is very much appreciated.

@hauserx
Copy link
Contributor

hauserx commented Nov 22, 2024

Added commit to fix failing tests under windows in #55, feel free to cherry-pick that commit to this PR or close the other PR if not useful.

This breaks rust-analyzer support otherwise
@cameron-martin cameron-martin mentioned this pull request Nov 25, 2024
5 tasks
@cameron-martin
Copy link
Owner Author

Thanks. I've added your commit to this PR since I had to fix a rust-analyzer issue too. I'll close your PR, but thanks for fixing this issue!

@hauserx
Copy link
Contributor

hauserx commented Nov 25, 2024

Could you also add test --test_output=errors to .bazelrc?

Or is it possible to make the buildbuddy links public / accessible (I guess it would should errors for tests as well). I am getting Permission denied for https://bazel-lsp.buildbuddy.io/invocation/5e19d021-dbe4-4a27-86aa-bb04c9cdf2a7

@cameron-martin
Copy link
Owner Author

cameron-martin commented Nov 25, 2024

I believe this issue is fixed now, but I've enabled a setting that should make builds public in #58.

@cameron-martin cameron-martin merged commit b4ded00 into master Nov 25, 2024
5 checks passed
@cameron-martin cameron-martin deleted the windows-build branch November 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants