Add support for onAbort argument on XHR.perform #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XHR.perform
method creates aK.stream
and emits value by binding tosome
XMLHttpRequest
events. That way you can be notified about thisrequest state changes through observable events.
*Extracted from Kefir docs.
While the request is correctly aborted when the request observable is
unsubscribed, the event is not propagated to the observable chain given
they have already been unsubscribed. I'm not familiar with any solution
within Kefir realm that would allow us to be notified of such changes,
and while one could probably create an abstraction on top of
XHR.perform
to run a custom code on abortion (unsubscription), itseems weird not to provide a solution for this problem.
The proposal is to support a custom
onAbort
argument when callingXHR.perform
that will be executed when the request is deactivated andsubsequently aborted.