Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] error screens in view plants & review add details #65

Merged
merged 12 commits into from
Dec 23, 2024

Conversation

SashankBalusu
Copy link
Contributor

@SashankBalusu SashankBalusu commented Dec 21, 2024

What's new in this PR πŸ§‘β€πŸŒΎ

Description

  • styled error screens in View Plants
    1. user not logged in β†’ "Log In to view plants"
    2. user not onboarded β†’ "Complete Onboarding to view plants"
    3. user has no plants yet β†’ "Add Plants"
    4. no matching plants β†’ "No Matching Plants" + "Clear Filters & Search"
  • styled the Review Add Details page
    • note: the review page is not currently editable
  • misc
    • consolidated dropdown filter options in utils/dropdownOptions.ts
    • added "full-screen" (100vh - 60px, i.e. full screen below the header) as a possible height option for Box and Flex

Screenshots

Screenshot 2024-12-21 at 12 34 46β€―AM Screenshot 2024-12-21 at 12 34 36β€―AM Screenshot 2024-12-21 at 12 34 30β€―AM Screenshot 2024-12-21 at 12 35 18β€―AM

Review Add Details
9b1ca940-4f53-469a-8af8-1b62ba072342

How to review

Next steps

  • possibly clean up other dropdownOptions so there's a single source of truth
  • decide whether we want No Matching Plants button to include "Clear Filters & Search" or just "Clear Filters"
  • decide if we want to make Review Add Details editable

Relevant links

Online sources

Related PRs

CC: @ccatherinetan

@ccatherinetan ccatherinetan changed the title styling for screens when somethings wrong in view plants [style] error screens in view plants & review add details Dec 23, 2024
@ccatherinetan ccatherinetan marked this pull request as ready for review December 23, 2024 03:50
@ccatherinetan ccatherinetan merged commit 5159c2a into main Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants