[feat] profile context integration with view plants and add details #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccatherinetan
changed the title
ccatherinetan
force-pushed
the
58-use-profilecontext-in-view-plants-and-add-details
branch
from
ee84673 to
407fa28
Compare
ccatherinetan
force-pushed
the
58-use-profilecontext-in-view-plants-and-add-details
branch
from
869222b to
7d8ef47
Compare
components/NavigationBar/index.tsx
Outdated
There was a problem hiding this comment.
should we remove this file if we're not using it anywhere?
| ); | ||
| const router = useRouter(); | ||
|
|
||
| const getDefaultDate = () => new Date().toISOString().substring(0, 10); |
There was a problem hiding this comment.
note: this date is a little funky. it's 1:48am 12/13, but the plant i just added says 12/12.
Perhaps we should look into other date formatting options e.g. toLocaleDateString() and set it to US Eastern Time, since that's where users will be.
| const router = useRouter(); | ||
|
|
||
| if (profileReady && !profileData) { | ||
| router.push('/view-plants'); |
There was a problem hiding this comment.
note: we should replace all routes with CONFIG
e.g.
import CONFIG from '@/lib/configs';
<Link href={CONFIG.login}>Login</Link>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
Screenshots
enabled next (when planting type is filled out)
disabled next
How to review
Next steps
userId!labelprop toplaceholderlabelprop that displays the label of the inputRelevant links
Online sources
Related PRs
CC: @ccatherinetan