[feat] create a textinput component + style auth flows #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccatherinetan
changed the title
This was
linked to
issues
Dec 13, 2024
Closed
ccatherinetan
force-pushed
the
rachaelchen/33-create-a-textinput-component-2
branch
from
263d7b3 to
8e2f7e2
Compare
| toggleVisibility, | ||
| error, | ||
| }) => { | ||
| const inputType = type === 'password' && isVisible ? 'text' : type; |
components/TextInput/index.tsx
Outdated
| error?: boolean; | ||
| } | ||
|
|
||
| const TextInput: React.FC<TextInputProps> = ({ |
There was a problem hiding this comment.
for consistency in the codebase, we want to declare components using
export default function TextInput({
label,
id,
type,
onChange,
isVisible,
value,
toggleVisibility,
error,
}: TextInputProps) {
...
}
app/(auth)/signup/page.tsx
Outdated
Comment on lines
112
to
114
| if (result.error.message === 'Account already exists for this email') { | ||
| setCheckEmailExistsError(result.error.message); | ||
| } |
There was a problem hiding this comment.
we want to catch all other possible errors too, so we don't need this conditional wrapper
app/(auth)/signup/page.tsx
Outdated
| string | null | ||
| >(null); | ||
| const [passwordComplexity, setPasswordComplexity] = useState<boolean>(false); | ||
| const [samePasswordCheck, setSamePasswordCheck] = useState(''); |
There was a problem hiding this comment.
this state can be inferred from password and confirmPassword states (i.e. just use password===confirmPassword when needed). You can use a constant instead of creating a new state.
api/supabase/queries/users.ts
Outdated
There was a problem hiding this comment.
note: i realized supabase login function already handles this error, so we might be able to remove this query later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
Screenshots
Sign Up
User Alr Registered Error
Invalid Email Error
Disabled SignUp (if password complexity not met, passwords don't match, or any fields blank)
Login
Invalid login credentials error
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @ccatherinetan