[feat] refactor add plant details #25
Conversation
ccatherinetan
changed the title
app/add-details/page.tsx
Outdated
|
|
||
| export default function Home() { | ||
| const [currentIndex, setCurrentIndex] = useState<number>(1); | ||
| const [details, setDetails] = useState<Partial<UserPlants>[]>([]); |
There was a problem hiding this comment.
can we make this a variable and not a state?
| return; | ||
| } | ||
| if ( | ||
| steps !== 0 && |
There was a problem hiding this comment.
is there ever a case where steps===0? Would you be calling this function if they're not clicking Back/Next?
app/add-details/page.tsx
Outdated
| currentIndex + steps <= plants.length + 1 | ||
| ) { | ||
| if (steps > 0) { | ||
| setIsDisabled(true); |
There was a problem hiding this comment.
just to confirm, this means if they're moving forward, the Next/Back buttons are disabled, but if they're moving backwards that means they've alr completed the previous page, so they should be able to move from the previous page
app/add-details/page.tsx
Outdated
| const updatedDetails = [...details]; | ||
| updatedDetails[currentIndex - 1] = { | ||
| ...updatedDetails[currentIndex - 1], | ||
| [field]: value, | ||
| plant_id: plants[currentIndex - 1].id, | ||
| }; | ||
| setDetails(updatedDetails); |
There was a problem hiding this comment.
this will need to updated since details shouldn't be a state
app/add-details/page.tsx
Outdated
| } | ||
|
|
||
| function updateDB() { | ||
| updateUserPlants(user_id, details); |
There was a problem hiding this comment.
This should be async, so we should modify this to:
async function updateDB() {
await updateUserPlants(user_id, details);
router.push('/view-plants');
}
Awaiting ensures that updateUserPlants is completed before rerouting to /view-plants, so that the changes made in the Add Plant Details flow are reflected in /view-plants.
ccatherinetan
force-pushed
the
22-refactor-add-plant-details
branch
from
c85195a to
d2900c2
Compare
What's new in this PR 🧑🌾
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @ccatherinetan