[feat] Create my plants and all plants tabs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/calblueprint/trap-garden into sashankbalusu/tg-16-create-the-plantcard-component
There was a problem hiding this comment.
looking great so far, thanks for the great work! a couple things
- the current get_plant_by_id query doesn't seem to be working; i left some code for a new query if you want to use that
- we can use ternary statements to simplify the logic (see comments)
- if you have time: try to use styled components instead of css (this might be something you want to do on the previous PlantCard sprint)
Co-authored-by: Catherine Tan <[email protected]> Co-authored-by: rachaelch3n <[email protected]> Co-authored-by: Catherine Tan <[email protected]>
Co-authored-by: Catherine Tan <[email protected]>
There was a problem hiding this comment.
looking great, sashank! to summarize the most important points:
- rebase for the updated
getAllPlantsandgetPlantByIdqueries - add extra filter in the supabase query to ensure that we're not fetching plants that are alr harvested (check that date_harvested is not null)
- check that the
fetchUserPlantsfunction works correctly - we might consider creating separate components that takes in the
seeMyPlantsto simplify the toggling logic between the two (let's discuss in worksesh!)
…thub.com/calblueprint/trap-garden into Create-My-Plants-and-All-Plants-Tabs-#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @ccatherinetan