Andrei/phs 25 home screen redo #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahhpeng
approved these changes
Mar 16, 2024
sarahhpeng
added a commit
that referenced
this pull request
Mar 16, 2024
* ra * fix phs 26 changed display.id to otherDisplay.id * raaaaa * phs-37 is done * changed settings josn * Christophertorres/phs 36 featured tours image carousel (#37) * feat: add buttons for navigating images * add image carousel to tour displays * fix: minor styling changes to meet larger text inputs * feat: more linting * feat: more linting II * chore: pre-push reformatting * feat: aggressive pre-commit checks * feat: use lint-staged instead * chore: updated types * feat: run tsc on staged files * chore * feat: disabling github actions until MPH / post-MPH * chore: prettier * chore: disabled only the tsc compiler for now * feat: disabling github actions for now * Andrei/phs 25 home screen redo (#38) * styling ok on phones * updated types * fixed global styling * config fix * feat: Global styling + Welcome graphic on home screen * feat: basic frontend for spotlight carousel * feat: basic visitor resources buttons * feat: routing from home page buttons added, WIP: bugs with rpc function * chore: added docs to pages * fix: changed styling for other phone screens * rpc functions added * feat: rpc function added to media spotlights on home page * chore: commented out related spotlight for now * style: changed div styling to meet tailwind conventions + base styling * chore: extra changes from supabase types sync * chore: removed console logs * chore: prettier script * chore: supabase types changed again * fix: incorrect function call + extra console log removed * style: fixing the spacing on the visitor resources buttons * chore: supabase sync * chore: comment fix * feat: fixed some styling, added routing to the wildlife carousel * chore: supabase sync * feat: updated to match RPC DB func changes * chore: removed unnecessary useEffect * chore: removed imports --------- Co-authored-by: sarahhpeng <[email protected]> * commit limits * phs-37 is done * donw with committing * ra * fix phs 26 changed display.id to otherDisplay.id * raaaaa * phs-37 is done * commit limits * phs-37 is done * donw with committing --------- Co-authored-by: sarah <[email protected]> Co-authored-by: Chris Torres <[email protected]> Co-authored-by: Andrei Tan <[email protected]> Co-authored-by: sarahhpeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ New in this PR ✨
One liner: what did you do? 🛠
Home page of PHS site, leads to other major features
Coverage 🙆♀️
use this section to break up your task into submodules and track progress, copy from Linear and mark what was completed
How can the reviewer test your code? Where is this sprint located in the codebase? 👩💻
Look at
src/app/page.tsx, made helper components to break up the pageREQUIRED: Link a short video demo of the feature you have added. 👩💻
https://www.loom.com/share/1620aecf5aea4a5bbcf463ed91ad2b8f?sid=d9d1cafe-c837-4545-892b-0b9bf57d0e83
Any bugs you encountered or still having trouble with? 🐛
Resources 📔
REQUIREMENTS in this section: Link all relevant online resources and related PRs. Write down any new dependencies or packages and link to their documentation. If you ran into bugs, link any stack overflow or online resources that helped you unblock yourself
For future use, we will probably want to use RPC database functions, especially for joins. I made a guide on notion on how to replicate.
❗IF this sprint was marked as FRONTEND on linear, cc Claire Wang
@cluurie
REMEMBER: once PR is made, also request a PR review Sarah, CC'ing is NOT enough!
🏚 cc: @sarahhpeng @andreisito