Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22 Wrap Up Prea Videos #26

Merged
merged 2 commits into from
Nov 19, 2024
Merged

22 Wrap Up Prea Videos #26

merged 2 commits into from
Nov 19, 2024

Conversation

CodyGarciaa
Copy link
Contributor

What's new in this PR

Description

  • still working on the video player, having some trouble with react native and using ios/android specific video players?
  • added new individual posters to pages on the Legal Rights page
  • added new videos to play with corresponding pages (yipeee we have actual videos and resources now lmao)

Screenshots

IMG_6D56B537BD44-1

How to review

  • mainly just Video Page and Legal Rights index
  • added a new command in storage queries to retrieve posters in the Legal Rights page

Next steps

  • the video player is still a work in progress, at this point its still just looping the video without the user able to control it
  • also, for now, I feel like the poster rendering, the video playing, etc. etc. is not robust yet. I still want to tweak the code some more and add failsafes so that in case one or the other is missing from the Supabase table or storage, it will still work but with just a placeholder

Relevant links

Online sources

Related PRs

CC: @insert pl github username here
@philipye314

@CodyGarciaa CodyGarciaa linked an issue Nov 18, 2024 that may be closed by this pull request
@philipye314 philipye314 merged commit 8f0a6e2 into main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap up PREA Videos
2 participants