Charlottelaw/jdi-7-navigation-drawer #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipye314
reviewed
Oct 27, 2024
Merged
CharlotteLaw
dismissed
philipye314’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
[Updated my old PR as of Nov 17] Used the Drawer Navigation documentation in React Native to create a side-bar for navigation for the Hope for Healing Guide. Created subsection functionality so that when you click Chapter 1, there is a drop down for subsections.
Screenshots
How to review
All of my changes were only in the
src/screens/HealingResources/HopeHealingGuide/index.tsxfile. You can take a look at that whole file. TheChapterOneNavigator()may error out in prettier/eslint because it is unused but I am keeping it here because I will be using it in the future for stack navigation within chapters. TheDrawer.Navigatorwrapper in the export function forHopeHealingGuidestores the screen logic for now.Next steps
Look at Angeline's PR to see how she did the accordion menu so I can use similar implementation for the Chapter drop down to display the subsections of each chapter. Later on, I will use a map function to dynamically display out all the drawer navigation screens instead of brute-forcing it like what we are doing right now.
Relevant links
Online sources
https://reactnavigation.org/docs/drawer-based-navigation
Related PRs
Not sure yet?
CC: @philipye314